fix: handle require calls that are side effect only #67
+25
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
requirecalls for side effects only (eg. where exports are not used) get converted to a namespace import which fails when the imported module has no exports.will become something like
which will error when
foohas no exports.This PR adds support for require calls that are for side effects only by checking if the parent AST node of the
requireCallExpression is an ExpressionStatement and replacing that entire node with the side-effect import.will become