-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Switch to Argos & fix E2E tests #1949
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bprusinowski
force-pushed
the
feat/switch-to-argos
branch
from
January 7, 2025 13:36
1cd9d07
to
928e25f
Compare
bprusinowski
force-pushed
the
feat/switch-to-argos
branch
from
January 7, 2025 14:13
5827bcb
to
d5981c3
Compare
bprusinowski
changed the title
feat: Switch to Argos
feat: Switch to Argos & fix E2E tests
Jan 7, 2025
noahonyejese
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff! 🎉
…into feat/switch-to-argos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1270
This PR:
I also took another look at e2e tests and managed to fix them (at least they work as of now 😅) – which means from now on we should strive to have "green light" on CI checks before merging. We'll have to see how stable they are in time, as in the past both cubes used to change often and LINDAS was very unstable, which improved over the years 🤞
If they will break often, we might need to re-record HAR traces and enable HAR on CI, but for now I'd check with how well it works by connecting directly to LINDAS.
📸 The Argos results are publicly visible under https://app.argos-ci.com/interactive-things/visualization-tool. Once we merge to
main
, we'll have baseline screenshot to compare to, now we only have orphan builds.