Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch to Argos & fix E2E tests #1949

Merged
merged 15 commits into from
Jan 8, 2025
Merged

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Jan 7, 2025

Closes #1270

This PR:

  • adds back screenshot testing using Argos (including screenshots of failed tests, so it's much easier to know what and how exactly failed by going to Argos PR build),
  • fixes e2e tests,
  • fixes "Score" sorting option being not available to select in dataset search results.

I also took another look at e2e tests and managed to fix them (at least they work as of now 😅) – which means from now on we should strive to have "green light" on CI checks before merging. We'll have to see how stable they are in time, as in the past both cubes used to change often and LINDAS was very unstable, which improved over the years 🤞

If they will break often, we might need to re-record HAR traces and enable HAR on CI, but for now I'd check with how well it works by connecting directly to LINDAS.

📸 The Argos results are publicly visible under https://app.argos-ci.com/interactive-things/visualization-tool. Once we merge to main, we'll have baseline screenshot to compare to, now we only have orphan builds.

Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 8:54am

@bprusinowski bprusinowski changed the title feat: Switch to Argos feat: Switch to Argos & fix E2E tests Jan 7, 2025
@bprusinowski bprusinowski marked this pull request as ready for review January 7, 2025 16:08
Copy link
Contributor

@noahonyejese noahonyejese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice stuff! 🎉

e2e/har-utils.ts Outdated Show resolved Hide resolved
@bprusinowski bprusinowski merged commit e9b787a into main Jan 8, 2025
11 checks passed
@bprusinowski bprusinowski deleted the feat/switch-to-argos branch January 8, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch back to Argos for screenshot testing
2 participants