Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Footer to Profile Page #1947

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

noahonyejese
Copy link
Contributor

This PR

Description
This PR adds the Footer to the Profile Page

@noahonyejese noahonyejese self-assigned this Jan 7, 2025
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 8:17am

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @noahonyejese!

A friendly reminder for the CHANGELOG entry, I've added a PR template in https://github.com/visualize-admin/visualization-tool/pull/1913/files#diff-b2496e80299b8c3150b1944450bd81c622e04e13d15c411d291db0927d75fd6b so we don't forget about it, it also often happens to me 😅

app/login/utils.ts Outdated Show resolved Hide resolved
app/pages/profile.tsx Show resolved Hide resolved
app/login/components/profile-content-tabs.tsx Outdated Show resolved Hide resolved
@noahonyejese noahonyejese merged commit 31c183d into main Jan 8, 2025
3 of 4 checks passed
@noahonyejese noahonyejese deleted the fix/add-footer-to-profile branch January 8, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✓ Show Footer in User Profile
2 participants