Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed map radiusScale for increased size for small values #1945

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

noahonyejese
Copy link
Contributor

This PR

Description
Values that are null, undefined or 0 will be not displayed and values that are very small will be scaled up slightly. In the future it might make sense to display null, undefined and 0 visibly in some form.

@noahonyejese noahonyejese self-assigned this Jan 7, 2025
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 8:31am

Copy link
Collaborator

@bprusinowski bprusinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'd only add a CHANGELOG entry and potentially add the comment back 😄

app/charts/map/map-state.tsx Outdated Show resolved Hide resolved
@noahonyejese noahonyejese merged commit bc6676a into main Jan 8, 2025
3 of 4 checks passed
@noahonyejese noahonyejese deleted the fix/maintenance-enhancements branch January 8, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small objects in map can end up TOO small
2 participants