fix: Keep color mapping up to date #1943
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1513
This PR makes sure we keep the
colorMapping
up to date in case new values appear in the cube (only possible when editing a chart that's based on a cube that was updated with a new value in dimension used as a color dimension after the chart was initially made). It also makes sure we keep old colors for existing values when updating thecolorMapping
.How to test
How to reproduce
See #1513 (copy and edit the chart, see that the values are not in the filters panel)