feat: Login improvements #1210
Merged
feat: Login improvements #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and include combo component iris when during the extraction.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
… change ...plus pass userId to the props.
bprusinowski
force-pushed
the
feat/login-continuation
branch
from
5f9959e to
3b0865c
Compare
ptbrowne
approved these changes
Oct 12, 2023
| userConfigs: ParsedConfig[]; | ||
| }; | ||
|
|
||
| export const ProfileContentTabs = (props: ProfileContentTabsProps) => { | ||
| const { userConfigs } = props; | ||
| const { userId, userConfigs: _userConfigs } = props; | ||
| const [userConfigs, setUserConfigs] = React.useState(_userConfigs); |
There was a problem hiding this comment.
Not sure I understand the change 🤔 ?
There was a problem hiding this comment.
Ah, this commit was a preparation for the next one, probably they should be one – as we fetch the user configs on the server side, there was a need to useState so that when user removes a chart, we can simply handle the change on the frontend, without re-querying configs (+ to make the table re-render once it's removed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes towards #1190.
This PR adds:
It also fixes a problem of not extracting components iris for combo charts and not carrying over the locale when clicking
Browse all datasetsbutton.