Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow edition of published charts #1208

Merged
merged 7 commits into from
Oct 11, 2023

Conversation

bprusinowski
Copy link
Collaborator

@bprusinowski bprusinowski commented Oct 10, 2023

This PR allows the edition of published charts.

  • Configurator state key is now stored inside the config
  • During publishing, we check if user is logged in and if a chart of given id exists in the database; if so, we update the chart config, assuring that they can only update the charts they created (client side and API side guards)
  • New ?edit=configuratorStateKey initializes chart state with configuratorStateKey = edit mode
  • Old ?from=configuratorStateKey initializes chart state with a new chart id = new chart mode

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
visualization-tool ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 7:27am

@bprusinowski bprusinowski merged commit ecb7add into main Oct 11, 2023
3 of 4 checks passed
@bprusinowski bprusinowski deleted the feat/allow-editing-charts-when-logged-in branch October 11, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants