Fix bar width when using ANSI styling #160
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPatchane
added a commit
to cozy/create-cozy-app
that referenced
this pull request
Jan 21, 2019
CPatchane
added a commit
to cozy/create-cozy-app
that referenced
this pull request
Jan 21, 2019
CPatchane
added a commit
to cozy/create-cozy-app
that referenced
this pull request
Jan 21, 2019
|
Why this isn't pushed to npm ? I had to fiddle with source code to find out why the output is shorter when using cli-colors. Thanks to this fix i was able to get it working quite easily although editing the source code manually is not a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue when using colors that the progress bar will usually be collapsed. It strips the ANSI styling when calculating the available space and works with the raw data being displayed.
The regex was taken from: https://github.com/chalk/ansi-regex/blob/master/index.js#L3 and seems to work well.