Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CI workflow improvements #2380

Merged
merged 3 commits into from
Apr 25, 2024
Merged

chore: CI workflow improvements #2380

merged 3 commits into from
Apr 25, 2024

Conversation

Pessimistress
Copy link
Collaborator

@Pessimistress Pessimistress commented Apr 25, 2024

  • Use Node 18
  • Use access token with stricter scope
  • Explicit hash for external tasks
  • Handles unannotated git tag in the CI context

Copy link
Contributor

@chrisgervang chrisgervang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's security/release model?

Is the security model that only authorized people can push to branches?

Is release done when a new tag is made, or triggered by something?

@Pessimistress Pessimistress changed the title chore: release workflow improvements chore: CI workflow improvements Apr 25, 2024
@Pessimistress
Copy link
Collaborator Author

This repo does not do CI releases yet. Push permission is limited for master, gh-pages, and *-release branches. They are managed in the repository settings.

@Pessimistress Pessimistress merged commit 0a8aa74 into master Apr 25, 2024
2 checks passed
@Pessimistress Pessimistress deleted the x/release-token branch April 25, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants