[fix] id in LayerProps should be optional (#1910)

visgl · Jul 5, 2022 · 60a560f · 60a560f
1 parent 851313c
commit 60a560f
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/components/layer.ts b/src/components/layer.ts
@@ -5,8 +5,11 @@ import {deepEqual} from '../utils/deep-equal';
 
 import type {MapboxMap, AnyLayer} from '../types';
 
-export type LayerProps = AnyLayer & {
-  id?: string;
+// Omiting property from a union type, see
+// https://github.com/microsoft/TypeScript/issues/39556#issuecomment-656925230
+type OptionalId<T> = T extends {id: string} ? Omit<T, 'id'> & {id?: string} : T;
+
+export type LayerProps = OptionalId<AnyLayer> & {
   /** If set, the layer will be inserted before the specified layer */
   beforeId?: string;
 };