-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Build node workers as ES modules #2791
base: master
Are you sure you want to change the base?
Conversation
The error is "Worker exception: Error: Dynamic require of "stream" is not supported" |
Can you pintpoint the line where this is happening? Since I can't find it in the source code I am assuming it is happening in the built code. But if we are building with --format=esm, seems that require shouldn't be emitted, so it is a mystery error? |
Probably, the root cause is in decoder/encoder libs ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tile converter fails with "Worker exception: Error: Dynamic require of "stream" is not supported". Probably draco encoder/decoder libs a not compatible with esm.
Yes that could be. I suppose if they were renamed to .cjs it might work. I guess in that case we'd need to copy them from the Google CDN. |
39020b8
to
57e1b9f
Compare
@belom88 Can you take another look at this now that it is rebased on the new build system. Do your concerns still apply? |
@belom88 Is it possible to test with this branch?