chore: webgpu deck enabler #9528
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixpalmer
approved these changes
Mar 17, 2025
| @@ -117,6 +117,9 @@ export type DeckProps<ViewsT extends ViewOrViews = null> = { | |||
| /** Use an existing luma.gl GPU device. @note If not supplied, a new device will be created using props.deviceProps */ | |||
| device?: Device | null; | |||
|
|
|||
| /** Supply adapters to use when a new device is created */ | |||
| adapters?: Adapter[]; | |||
There was a problem hiding this comment.
I thought adapters would be added via luma.registerAdapters?
There was a problem hiding this comment.
I thought adapters would be added via
luma.registerAdapters?
registerAdapters is still supported, but generally I find that global registration creates as many problems as it solves, so added the capability to specify adapters explicitly.
|
Closed via #9432, which leverages the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Background
Change List