Exemplar view modifications#214
Merged
Merged
Conversation
Luke-Schreiber
force-pushed
the
exemplar-view-modifications
branch
from
2272989 to
ba1dabe
Compare
Author
|
Closed
Luke-Schreiber
added
frontend
There was a problem hiding this comment.
Pull request overview
This PR updates the Exemplar View UI/interaction behavior, focusing on layout/spacing tweaks, tooltip styling, and improved reactivity for snippet/selection highlighting, along with some refactoring/organization.
Changes:
- Adjusts default exemplar view spacing and adds
histogramConditionLabelWrapFactorconfiguration. - Adds a consolidated “Size” control in the settings toolbar and reorganizes settings sidebar sliders into accordion sections.
- Refactors ExemplarView rendering/interaction logic, including a new DOM-based histogram tooltip and segmentation-based snippet cropping.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| apps/client/src/stores/componentStores/ExemplarViewStore.ts | Updates default sizing/spacing values and adds histogramConditionLabelWrapFactor to view configuration. |
| apps/client/src/components/exemplarView/ExemplarViewSettingsToolbar.vue | Adds a combined size slider that scales snippet size and derived heights. |
| apps/client/src/components/exemplarView/ExemplarViewSettingsSidebar.vue | Categorizes sliders and groups them into accordion sections. |
| apps/client/src/components/exemplarView/ExemplarView.vue | Refactors rendering/hover/selection logic, introduces DOM histogram tooltip, and adds segmentation-based cropping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Author
|
This comment was marked as outdated.
This comment was marked as outdated.
Author
We will have this in another PR I think |
Author
|
Author
|
Tick marks truncate, and add more vertical margin between exemplars 
|
Dev-Lan
approved these changes
Apr 3, 2026
github-project-automation
Bot
moved this from In review
to Done
in Loon Feature Planning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes #
Give a longer description of what this PR addresses and why it's needed