Skip to content

fix lora and adapterbias implementation error #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wind-apprentice wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix lora and adapterbias implementation error #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e9cead
fix lora and adapterbias implementation error
wind-apprentice Oct 27, 2023
38d24ff
Update adapters.py
wind-apprentice Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions adapter_bert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ def __init__(self, BertOutput, config):
self.adapter = HoulsbyAdapter(config.hidden_size)
elif config.adapter == "conv_adapter":
self.adapter = ConvAdapter(config.max_position_embeddings)
elif self.adapter == "AdapterBias":
elif config.adapter == "AdapterBias":
self.adapter = AdapterBias(config.hidden_size)
elif self.adapter == "lora":
elif config.adapter == "lora":
self.adapter = LoRA(config.hidden_size)
else:
raise NotImplementedError
Expand Down
3 changes: 2 additions & 1 deletion adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import torch
from torch import nn
import loralib as lora


class HoulsbyAdapter(nn.Module):
Expand Down Expand Up @@ -73,4 +74,4 @@ def __init__(
self.lora_adapter = lora.Linear(input_size, input_size, r)

def forward(self, x):
return self.lora_adapter(x)
return self.lora_adapter(x)