-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spree 4.1 #45
base: master
Are you sure you want to change the base?
spree 4.1 #45
Conversation
@@ -4,6 +4,10 @@ gem 'spree', github: 'spree/spree', branch: 'master' | |||
# Provides basic authentication functionality for testing parts of your engine | |||
gem 'spree_auth_devise', github: 'spree/spree_auth_devise', branch: 'master' | |||
|
|||
gem 'byebug', '~> 9.0.6' | |||
gem 'byebug', '>= 9.0.6' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why >= ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to gemspec
@@ -1,2 +1,5 @@ | |||
//= require 'spree/backend/returns/return_item_selection' | |||
//= require 'spree/frontend/return_item_options_selection' | |||
//= require jquery | |||
//= require jquery_ujs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why require jquery_ujs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Could you please merge this pull request?
@tanmay3011 We are waiting to use this spree 4.1 support. Could you please merge this as early as possible? |
No description provided.