Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API endpoints for hardware models #237

Merged
merged 1 commit into from
Apr 22, 2020
Merged

API endpoints for hardware models #237

merged 1 commit into from
Apr 22, 2020

Conversation

msk4862
Copy link

@msk4862 msk4862 commented Apr 14, 2020

Description

Added API endpoints for hardware model

Fixes #190

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@welcome
Copy link

welcome bot commented Apr 14, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

@msk4862
Copy link
Author

msk4862 commented Apr 14, 2020

@PragatiVerma18 please review the changes.

@auto-assign auto-assign bot requested a review from vinitshahdeo April 14, 2020 19:34
PragatiVerma18
PragatiVerma18 approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work @msk4862!! Keep contributing.

@PragatiVerma18 PragatiVerma18 added backend gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue labels Apr 22, 2020
@PragatiVerma18 PragatiVerma18 merged commit a61c5f4 into vinitshahdeo:feature/backend-django Apr 22, 2020
@welcome
Copy link

welcome bot commented Apr 22, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PragatiVerma18 PragatiVerma18 PragatiVerma18 approved these changes

@vinitshahdeo vinitshahdeo Awaiting requested review from vinitshahdeo

Assignees

@vinitshahdeo vinitshahdeo

@msk4862 msk4862

Labels
backend gssoc20 Welcome to GirlScript Summer of Code 2020 medium medium level issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msk4862 @PragatiVerma18 @vinitshahdeo