Skip to content

Feature/#1 manage admin#4

Open
vincemillora wants to merge 5 commits intoDevlopfrom
feature/#1_manage-admin
Open

Feature/#1 manage admin#4
vincemillora wants to merge 5 commits intoDevlopfrom
feature/#1_manage-admin

Conversation

@vincemillora
Copy link
Owner

No description provided.

@vincemillora vincemillora requested review from andy1dx and hugh-n April 25, 2019 08:44
@andy1dx
Copy link
Collaborator

andy1dx commented Apr 25, 2019

please add

closes #[issues number]

$table->string('admin_username', 50);
$table->string('password', 25);
$table->timestamp('date_created');
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add is active column

Schema::create('blog_posts', function (Blueprint $table) {
$table->increments('post_id');
$table->string('post_title', 100);
$table->string('post_message', 500);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$table->string('post_message', 500);
$table->longtext('post_content');

Copy link
Collaborator

@andy1dx andy1dx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleasecheck the comment

@vincemillora
Copy link
Owner Author

Done integrating the comments. Please re-check.
Thank you.

@vincemillora vincemillora requested a review from andy1dx April 26, 2019 06:38
Copy link
Collaborator

@andy1dx andy1dx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix add is active for admin also

@vincemillora
Copy link
Owner Author

Done adding the is active for the admin

@vincemillora vincemillora requested a review from andy1dx April 26, 2019 07:08
vincemillora pushed a commit that referenced this pull request Apr 26, 2019
vincemillora pushed a commit that referenced this pull request Apr 26, 2019
Copy link
Collaborator

@hugh-n hugh-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me. Need to wait for Andy to approve changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants