unokai colorscheme

[k-37]

The colorscheme is inspired by Monokai. #270

habamax colorscheme was used as a starting point. Color palette is based on this one.

GUI

256 colors

16 colors

8 colors

[romainl]

Thank you very much. We will take a look as soon as possible.

[romainl]

This seems to work very well. My only (minor) gripes would be with…

• the way the number of windows is highlighted in a tab:

  

  FWIW, it is handled via the Title highlight group.

• and possibly the lack of contrast in "inactive" UI sections. I tested with 244 instead of 242, here:

  

@habamax @neutaaaaan What do you think?

[habamax]

Looks good. Probably issue with my monitor setting, ErrorMsg is too dark for my eyes.

And yes, currently Title has the same color as Normal, instead guifg/ctermfg=NONE should be set to play nicely with tabpage.

[k-37]

@romainl and @habamax thank you for taking time to review the PR.

I just pushed changes regarding Title and "inactive" UI sections.

Is there a consensus what should be done about ErrMsg?

[neutaaaaan]

Just had a glance at it.

To me, Error and ErrMsg should have pure black text, and if possible a slightly brighter shade of red.
I'll play around with it this weekend.

[romainl]

I agree with @neutaaaaan's pure black suggestion.

[k-37]

Hi @neutaaaaan,

thank you for your suggestions.

Here it is.

GUI

256

16

[romainl]

I don't see any issue anymore. @habamax? @neutaaaaan?

[habamax]

Looks ok.

And as it is based on habamax, I would also "fix" #267 by adding PopupSelected link to PMenuSel.

[neutaaaaan]

I'm not crazy about the shade of cyan used for Special in 256c, but I haven't found a replacement that didn't clash with Statement.

As it's based on habamax, I figure it's robust enough, but I'd rather spend another week or so using it at work before really giving it my full approval.

[k-37]

And as it is based on habamax, I would also "fix" #267 by adding PopupSelected link to PMenuSel.

Link PopupSelected -> PmenuSel already exists.

[habamax]

Link PopupSelected -> PmenuSel already exists.

oh, that is great!

[k-37]

unokai is not just habamax with different color pallete, some other small changes were made.

Here is written all colorschemes must have the same features. What is considered feature of colorscheme?

Should this be removed:

;;; Syntax
Variant: 8
htmlBold                     color07        none           bold
htmlItalic                   color07        none           underline
Variant: gui 256 16
htmlBold                     color15        none           bold
Variant: 256 16
htmlItalic                   color15        none           underline
Variant: gui
htmlItalic                   color15        none           italic

Variant: 8
markdownHeadingDelimiter     color07        none
markdownH1Delimiter          color01        none
markdownH2Delimiter          color03        none
markdownH4Delimiter          color04        none
markdownH6Delimiter          color02        none
Variant: gui 256 16
markdownHeadingDelimiter     color15        none
markdownH1Delimiter          color09        none
markdownH2Delimiter          color11        none
markdownH4Delimiter          color12        none
markdownH6Delimiter          color10        none
Variant: gui 256 16 8
markdownH3Delimiter          color03        none
markdownH5Delimiter          color04        none

[romainl]

Here is written all colorschemes must have the same features. What is considered feature of colorscheme?

Sorry, that sentence should have been more precise, something like:

all colorschemes must have the same level of support for for the same core features

With "core features" referring to all the documented hl-something highlight groups. The goal is to provide the same basic level of functionality to every user. Whatever you can do in $BUNDLED_COLORSCHEME, you can do it just as well in any other $BUNDLED_COLORSCHEME and you can base your choice on other criteria like your own taste, lighting condition, display, etc.

[habamax]

vimrc looks too "red" with unokai, should preproc use other color or this is by design?

[habamax]

Looks like most vim monokai colorschemes do the same

[k-37]

That is by design.

[neutaaaaan]

After about a week of using the 256c version ofunokai at work I haven't noticed any real issues with it, and the minor gripes I have stem from choices made by the original author of monokai.

I trust @habamax and @romainl will have more thoroughly checked and tested the various templates.

As for the question about rewiring groups, we don't allow for anything that targets specific plugins or third party syntax files but anything that ships with vim is fair game, as long as things are semantically coherent, or are good faith attempts at resolving semantic conflicts caused by the design of the original colorscheme.

[romainl]

Thank you @k-37, I think we can merge this PR as-is.

@habamax, @neutaaaaan, @chrisbra, do you think we should make a PR to the main repo right away? Or should we wait until we have n more colorschemes/fixes and do a batch?

[chrisbra]

I don't mind, whatever works best for you

[neutaaaaan]

We might as well PR unokai right away, there's no telling when other colorschemes will be ready to be PRed as well.