Dbext ora extensions #25

ant0sha · 2023-09-03T11:55:30Z

Several general fixes for UTF8 and 2 new oracle+DBI specific extensions

Several general fixes for UTF8

- dbext_dbi_debug - changed spelling to use 'g:' prefix

- perl prologue - explicitly asking perl to use UTF8 in both source code
  and input/output encoding

- display of non-ASCII results (importang for UTF8!) of query is added
  (v26 had $val =~tr/\x80-\xFF/ /; which replaced all non-ASCII things
  with blanks)!

- db_print_results - fixed bug if empty line happened in the
  non-expected place

- FuzzyFinder badly interact with dbext in that it creates global
  variable FuzzyFinderMode

2 New oracle+DBI specific extensions:

- DBXtractDdl - new command which is only implemented for oracle/DBI
  driver

- DBEnableSrvOut
- DBDisableSrvOut - new commands to interact with dbms_output from
  oracle (enable/disable). dbms_output is enabled by default

- empty lines in output are forced to stay - otherwise output of DDL is
  not useable

downloaded in 2021 from www.vim.org - as is

Several general fixes for UTF8 - dbext_dbi_debug - changed spelling to use 'g:' prefix - perl prologue - explicitly asking perl to use UTF8 in both source code and input/output encoding - display of non-ASCII results (importang for UTF8!) of query is added (v26 had $val =~tr/\x80-\xFF/ /; which replaced all non-ASCII things with blanks)! - db_print_results - fixed bug if empty line happened in the non-expected place - FuzzyFinder badly interact with dbext in that it creates global variable FuzzyFinderMode 2 New oracle+DBI specific extensions: - DBXtractDdl - new command which is only implemented for oracle/DBI driver - DBEnableSrvOut - DBDisableSrvOut - new commands to interact with dbms_output from oracle (enable/disable). dbms_output is enabled by default - empty lines in output are forced to stay - otherwise output of DDL is not useable

Problem: dynamically linking perl is broken Solution: Fix all issues This is a combination of several commits: 1) Fix if_perl.xs not being able to build on all versions of Perl (5.30) This fixes the dynamic builds of Perl interface. The Perl interface file previously had to manually copy and paste misc inline functions verbatim from the Perl headers, because we defined `PERL_NO_INLINE_FUNCTIONS` which prevents us form getting some function definitions. The original reason we defined it was because those inline functions would reference Perl functions that would cause linkage errors. This is a little fragile as every time a new version of Perl comes out, we inevitably have to copy over new versions of inline functions to our file, and it's also easy to miss updates to existing functions. Instead, remove the `PERL_NO_INLINE_FUNCTIONS` define, remove the manual copy-pasted inline functions. Simply add stub implementations of the missing linked functions like `Perl_sv_free2` and forward them to the DLL version of the function at runtime. There are only a few functions that need this treatment, and it's a simple stub so there is very low upkeep compared to copying whole implementations to the file. Also, fix the configure script so that if we are using dynamic linkage, we don't pass `-lperl` to the build flags, to avoid accidental external linkage while using dynamic builds. This is similar to how Python integration works. 2) Fix GIMME_V deprecation warnings in Perl 5.38 Just use GIMME_V, and only use GIMME when using 5.30 to avoid needing to link Perl_block_gimme. We could provide a stub like the other linked functions like Perl_sv_free2, but simply using GIMME is the simplest and it has always worked before. 3) Fix Perl 5.38 issues Fix two issues: 3.1. Perl 5.38 links against more functions in their inline headers, so we need to stub them too. 3.2. Perl 5.38 made Perl_get_context an inline function, but *only* for non-Windows build. Fix that. Note that this was happening in Vim currently, as it would build, but fail to run Perl code at runtime. 4) Fix Perl 5.36/5.38 when thread local is used Perl 5.36 introduced using `_Thread_local` for the current context, which causes inline functions to fail. Create a stub `PL_current_context` thread local variable to satisfy the linker for inlined functions. Note that this is going to result in a different `PL_current_context` being used than the one used in the library, but so far from testing it seems to work. 5) Add docs for how to build Perl for dynamic linking to work closes: #12827 closes: #12914 Signed-off-by: Christian Brabandt <[email protected]> Co-authored-by: Yee Cheng Chin <[email protected]>

dfishburn · 2023-09-06T01:56:13Z

autoload/dbext_dbi.vim

+    # ans, 2022-04-08 - allow to print from dbms_output empty lines
+    my @lines = ();
+    if (!defined ($line_txt) || length($line_txt) == 0) {
+      @lines = ("");
+    } else {
+      @lines = split("\n", $line_txt);
+    }


Inconsistent indenting with the rest of the file.
The file should be 4 space expanded indenting.
I am surprised it is off given this line in the file (specifically for Vim)
" vim:fdm=marker:nowrap:ts=4:expandtab:

probably I manually ("unconsciously") removed extra spaces in that case (my "standard" ts = 2 usually)

autoload/dbext_dbi.vim

dfishburn · 2023-09-06T02:00:00Z

autoload/dbext_dbi.vim

+                #$temp_length = length((defined($col)?$col:""));
+                # For some reason the above can sometimes return the wrong length.
+                # The following two lines fix that problem
+                my $xstr = $col;
+                $temp_length = length((defined($col)?$xstr:""));
+


Hm but this not comes from me. I took that other from v26, downloaded in 2021 from vim scripts site.
Looking on that precisely I see no real reason for this change. As far as I can tell lines 1434+1435 doing exactly the same as line 1431 in the past?

(Well, single possible reason for difference which I can imagine is that encoding of the string is changed internally due to assignment but not the byte content of string - and it would be relevant only for some non-ascii bytes... But that's just a theory)

dfishburn · 2023-09-06T02:00:27Z

autoload/dbext_dbi.vim

+        #### THIS IS MAGIC !!!!!!!
+        #### THIS_IS_MAGIC !!!!!!!
+        #### THIS IS MAGIC !!!!!!!


What is magic?

I was too excited of being able to figure out, that decode('utf8', $str) solves the problem with dbms_output non-ASCII chars being wrongly encoded ))) Cleaned up this comments a bit as well as extracted example referenced which reproduces a problem as separate file on github (hope it is available publicly):

ant0sha@b83befa

autoload/dbext_dbi.vim

doc/dbext.txt

dfishburn · 2023-09-06T02:32:46Z

autoload/dbext_dbi.vim

+    db_debug("skip <enable> of already enabled server output");
+  }
+  else {
+    $conn_local->func( 1000000, 'dbms_output_enable' );


Would it make sense for this to be a variable so that it can be customized easily?

That would make perfectly sense but I have to find time yet to work on it. Next 2-3 weeks are quite tough on my side so I push now to get at least quick changes you requested done.

dfishburn · 2023-09-06T02:40:18Z

doc/dbext.txt

@@ -1,4 +1,4 @@
-*dbext.txt*	For Vim version 7.0.  Last change: 2016 Jan 03
+*dbext.txt*	For Vim version 7.0.  Last change: 2017 Nov 17


Can you add a section at the bottom of this file around:
17.13 DBI Tutorial dbext-tutorial-dbi
Wishes shows this feature in action.
A command you execute and the output you get to see.

Did some very "microscopic" documentation please have a look.

ant0sha · 2023-09-11T09:08:31Z

@dfishburn, done so far with "quick wins". Next 3 weeks will have very less time - perhaps only for very small things (like improve docu a bit if you will point to some specfic place).

TODO/still open:

configuration option to have dbms_output disabled or enabled (now default) on start
ora_charset, ora_ncharset parameters for DBI->connect call are hardcoded now as:

sub db_connect
{
...
                    ora_charset => 'AL32UTF8',
                    ora_ncharset => 'AL32UTF8',

Typically it has to be taken over from NLS_LANG environment variable. But because of some quirks it has not worked for me on cygwin with oracle instant client. Yet to try out regularly on linux, IMO not necessary as global default. But for cygwin case at least has to be as well made configurable.

ant0sha · 2023-09-11T09:18:29Z

TODO/continuation:

timestamps for query started/finished/printed added to the output after each query to be made configuration option:

query started: Mon Sep 11 11:15:23 2023
query finished: Mon Sep 11 11:15:23 2023
printed at: Mon Sep 11 11:15:24 2023

haron13-2019 added 2 commits September 3, 2023 13:24

dbext v26 from David Fishburn

37f4bf5

downloaded in 2021 from www.vim.org - as is

dfishburn suggested changes Sep 6, 2023

View reviewed changes

ant0sha force-pushed the dbext_ora_extensions branch from a92bdf9 to ae3533f Compare September 10, 2023 09:51

Adressed @dfishburn code review comments

8458ff0

ant0sha force-pushed the dbext_ora_extensions branch from ae3533f to 8458ff0 Compare September 10, 2023 10:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dbext ora extensions #25

Dbext ora extensions #25

ant0sha commented Sep 3, 2023

dfishburn Sep 6, 2023

ant0sha Sep 9, 2023

dfishburn Sep 6, 2023

ant0sha Sep 9, 2023

dfishburn Sep 6, 2023

ant0sha Sep 10, 2023 •

edited

Loading

dfishburn Sep 6, 2023

ant0sha Sep 10, 2023

dfishburn Sep 6, 2023

ant0sha Sep 10, 2023

ant0sha commented Sep 11, 2023

ant0sha commented Sep 11, 2023

		@@ -1,4 +1,4 @@
		dbext.txt For Vim version 7.0. Last change: 2016 Jan 03
		dbext.txt For Vim version 7.0. Last change: 2017 Nov 17

Dbext ora extensions #25

Are you sure you want to change the base?

Dbext ora extensions #25

Conversation

ant0sha commented Sep 3, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ant0sha Sep 10, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ant0sha commented Sep 11, 2023

ant0sha commented Sep 11, 2023

ant0sha Sep 10, 2023 •

edited

Loading