-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Bitwise enhance that is new method imported from vital-codec library's Vim.Type.Number module #675
Conversation
Hmm, as you've struggled, these functions are kind of in between Bitwise and Number. In my opinion, these functions must belong to Bitwise instead. I expect "Vim.Type.Number" to be more Vim's number specific utilities. Such that would not only include truncating upper bits of the internal representation of a number, but also include modulo, factorial, prime numbers, floating point numbers, or other varieties of them. |
👍 to move the functions to Bitwise module. |
OK move to Bitwise |
bd29138
to
da091c0
Compare
Hmmm. Vint review :
stay tune |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks!
Proposal new library
This library operate Number data
Numberについての型的な処理です。
rotate系はbitwiseとどちらか悩ましいですが、固定長の整数型のビット操作、という意味ではどちらもアリか、と思い、こちらに入れてます。
see #667
ID.UUID
Data.List.Byte
Vim.Type.Number
の依存関係から、まずVim.Type.NumberのPRになります。