Skip to content

Uniform sentence style of terminal.jax #1677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 15, 2024
Merged

Uniform sentence style of terminal.jax #1677

merged 7 commits into from
Sep 15, 2024

Conversation

h-east
Copy link
Member

@h-east h-east commented Sep 4, 2024

Related: #812

tsuyoshicho
tsuyoshicho reviewed Sep 7, 2024
View reviewed changes
Copy link
Contributor

@tsuyoshicho tsuyoshicho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

気付いた点についてコメント

h-east and others added 2 commits September 7, 2024 20:28
@h-east h-east requested a review from tsuyoshicho September 7, 2024 11:51
mityu
mityu reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@mityu mityu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L126 までみました。

@mityu
Copy link
Member

mityu commented Sep 14, 2024

L391 まで見ました。ここまでは LGTM です。

tsuyoshicho
tsuyoshicho reviewed Sep 15, 2024
View reviewed changes
@h-east @tsuyoshicho
Update doc/terminal.jax
b823df3 
Co-authored-by: Tsuyoshi CHO <[email protected]>
mityu
mityu reviewed Sep 15, 2024
View reviewed changes
Copy link
Member

@mityu mityu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2箇所変更漏れっぽいところに気づいたのでコメントしました。
どちらも行の整形込みで suggestion 作ろうとすると、対象となる範囲に行の追加と削除が入り混じることになって suggestion が作れないと言われてしまったので平文で失礼してます。

@mityu
Copy link
Member

mityu commented Sep 15, 2024

他は LGTM です 👍

@h-east h-east merged commit 407049f into master Sep 15, 2024
3 checks passed
@h-east h-east deleted the hh-uniform-style-terminal branch September 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsuyoshicho tsuyoshicho tsuyoshicho approved these changes

@mityu mityu mityu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@h-east @mityu @tsuyoshicho