-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update vim-vimlparser #48
update vim-vimlparser #48
Conversation
6f2f86d
to
342a3e0
Compare
342a3e0
to
ad5e5b0
Compare
0b547b9
to
adf1314
Compare
Awesome! Thank you for your work! Hmm.. the Travis commit integration doesn't work, but the Travis tests are still failing. (Maybe we need to migrate to GitHub Actions...) https://travis-ci.org/github/haya14busa/go-vimlparser/jobs/747912759 |
Also, I'm not actively maintaining this repository these days. |
Done. The Go version was old (1.8) so I updated to 1.14. |
Moving to vim-jp looks great, @mattn mentioned this topic on Slack. Better to include in vim-jp/vim-vimlparser or different repository? The code base is much different from js and py but maybe we can move into https://github.com/vim-jp/vim-vimlparser/tree/master/go/vimlparser and users can import the package. And running integrated tests is great because some changes has broke compiling to Go code. My concern is the vimlparser.vim in this repository is already diverted from the original due to |
Thank you for your work! 🚀 Yes! I also tried to add the Go change into the original vimlparser repo, but my concerns and problems were...
I propose to move the repo to vim-jp org as a separate repo as a first step and we can work on merging the repos later. |
Do not merge, this is still in progress...I finished the work and the tests finally pass!