Skip to content

perf(Game/IGame): speedup - #429

Open
plp127 wants to merge 1 commit into
vihdzp:masterfrom
plp127:aliu/fast-igame
Open

perf(Game/IGame): speedup#429
plp127 wants to merge 1 commit into
vihdzp:masterfrom
plp127:aliu/fast-igame

Conversation

@plp127

@plp127 plp127 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Speedup the slowest declarations in CombinatorialGames.Game.IGame.


@vihdzp

vihdzp commented Aug 8, 2026

Copy link
Copy Markdown
Owner

Since this PR isn't critical, can we perhaps wait for the Mathlib PR to get in first?

Also, I think I wrote some of these Set.forall_ lemmas in the GameCmp tactic file. Can you ensure they're not being duplicated there?

@plp127

plp127 commented Aug 8, 2026

Copy link
Copy Markdown
Contributor Author

Also, I think I wrote some of these Set.forall_ lemmas in the GameCmp tactic file. Can you ensure they're not being duplicated there?

indeed Set.forall_mem_union is in CombinatorialGames.Game.Loopy.Basic (but it's not public)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants