feat: ordinal powers of a field form a basis for nimbers - #348
Open
vihdzp wants to merge 13 commits into
Open
Conversation
Contributor
|
Why do you use |
Owner
Author
|
You're right, I've re-stated everything in terms of finsupps. |
vihdzp
commented
Mar 6, 2026
vihdzp
commented
Mar 8, 2026
plp127
reviewed
Aug 26, 2026
| /-- `toFinsupp b hb x e` returns the coefficient of `b ^ e` in `x`. This is a specialization of | ||
| `Ordinal.CNF.coeff`. -/ | ||
| @[pp_nodot] | ||
| def toFinsupp (x : Nimber) : Ordinal →₀ hb.toSubfield := |
Contributor
There was a problem hiding this comment.
Would it be possible to only expose the bundled LinearEquiv? I can't think of a scenario in which having a LinearEquiv instead of a plain function would be bad.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.