Skip to content

Conversation

@TheSin-
Copy link
Contributor

@TheSin- TheSin- commented Jan 24, 2024

Expose before_change_gcode and after_change_gcode to allow for user macros.

Example and use in viesturz/tapchanger#25

@BrewNinja
Copy link

Any movement on this?

@viesturz
Copy link
Owner

viesturz commented Apr 1, 2024

Finally getting back to this. Let me try yo understand the use case a bit better first, following up in the other PR.

@TheSin-
Copy link
Contributor Author

TheSin- commented Apr 1, 2024

It’s okay I started my own fork, i was trying to avoid it be at the rate of commits I had too much of a back log of features, requests and enhancements

@viesturz
Copy link
Owner

viesturz commented Apr 2, 2024 via email

@TheSin-
Copy link
Contributor Author

TheSin- commented Apr 2, 2024

sure it's in the StealthChanger repo, but it's not fit for release yet lots of checks and balances missing ATM, I'm just trying to slowly move through it.

That being said if you are willing to work on these with me I'd MUCH rather not fork, it's confusing for users, but I need to be able to get PRs in a bit quicker (that being said I truly appreciate your review of it and working together we can move it forward quicker).

https://github.com/Stealthchanger/klipper-toolchanger

@viesturz
Copy link
Owner

viesturz commented Apr 3, 2024

Was pretty much out the whole Q1, normally I'm quite responsive.
That being said, I'm looking to keep the toolchanger core minimalistic, so depending what you are looking to do, it might be easier to keep things separate with occasional pull requests.

For this PR speficially, it's not clear how the new fields would be used. Right now it's just dead code.

@viesturz
Copy link
Owner

viesturz commented Apr 3, 2024

I reorganized the examples folder, if you are interested to add a Stealthchanger example there.

@viesturz
Copy link
Owner

viesturz commented Jun 9, 2024

Hi, pushed 3bfc95b to address this.

@viesturz viesturz closed this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants