Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-track-settings): localization not correctly applied #8904

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

amtins
Copy link
Contributor

@amtins amtins commented Oct 29, 2024

Description

Localization is not applied correctly in fieldset labels and select options. As a result, the text track setting modal dialog is only half translated.

Screenshot from 2024-10-29 19-35-34

Specific Changes proposed

  • add localize at label level in TextTrackFieldset
  • add localize at option level in TextTrackSelect
  • add test cases

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Localization is not applied correctly in fieldset labels and select options. As
a result, the text track setting modal dialog is only half translated.

- add `localize` at `label` level in `TextTrackFieldset`
- add `localize` at `option` level in `TextTrackSelect`
- add test cases
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.25%. Comparing base (d2b9d5c) to head (4768c18).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8904      +/-   ##
==========================================
- Coverage   83.85%   83.25%   -0.61%     
==========================================
  Files         120      120              
  Lines        8097     8097              
  Branches     1944     1944              
==========================================
- Hits         6790     6741      -49     
- Misses       1307     1356      +49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. And it reminds me, we really ought to show a placeholder cue when that dialog is open at least when there isn't one showing, otherwise the truncated dialog seems strange.

@mister-ben mister-ben merged commit ecef37c into videojs:main Oct 30, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants