Conversation
Drop the closeWindow call from the closeTab action so vicinae stays focused after closing a browser tab. The tab list refreshes via BrowserExtensionService::tabsChanged in both the root search and the built-in browser tabs view, so the closed tab disappears on its own.
Adds a closeTab RPC to the tsapi schema so user extensions can close browser tabs from their own commands. Mirrors focusTab signature and routing. Generated tsapi.hpp and api.ts proto updated via figura codegen. Tab wrapper in browser.ts now exposes browserId and a close() helper matching focus().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
closeTab(browserId, tabId)to theBrowserExtensionRPC and surfaces it on the TS API namespace so custom extensions can close browser tabs.figura/tsapi.fig: addcloseTabtoBrowserExtensionserviceext-browser-extension-service.hpp: implement override (delegates toBrowserExtensionService::closeTab)api.ts(generated): TS client getscloseTabmethodbrowser.ts:Tabtype gainsbrowserIdandclose(); newBrowserExtension.closeTab(browserId, tabId)standalone helperVerification:
tsapi.hppregenerates withcloseTabvirtual + routingapi.tsregenerates withcloseTabmethodextension-runtime.jserror is pre-existing pnpm/TS dependency setup, unrelatedMirrors
focusTabsignature and routing.