Skip to content
This repository was archived by the owner on Dec 1, 2021. It is now read-only.

Several performance improvements and JSDoc fixes #8

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Several performance improvements and JSDoc fixes #8

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f3b3726
Improved performance for getTop
p-bakker Jun 5, 2018
c83d3d0
Flagged linkedTop param in JSDoc on set to be optional
p-bakker Jun 5, 2018
c2635d1
Fix type of value parameter on set function through JSDoc
p-bakker Jun 5, 2018
1166cbb
Higher performance due to skipping debug string concatenation unless …
p-bakker Jun 5, 2018
b840fe7
Updated misses debeg statements to higher performance approach
p-bakker Jun 5, 2018
a8c5185
Fixed typo
p-bakker Jun 5, 2018
6542da9
And 2 more typos
p-bakker Jun 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ const nano = require('nano-seconds');
const util = require('util');
const fs = require('fs');


const map = new Map();

const enabledDebug = process.env.DEBUG === 'als';
Expand Down Expand Up @@ -45,10 +44,10 @@ function get(data, key) {
* Get the top data
*/
function getTop(data) {
if (!data.parent) {
return data;
while (data.parent) {
data = data.parent
}
return getTop(data.parent);
return data
}

let currentId = 0;
Expand All @@ -66,7 +65,7 @@ const hooks = asyncHooks.createHook({
data.parent = parent;
}
}
debug(`${id}(${type}) init by ${triggerId}`);
debug('%d(%s) init by %d', id, type, triggerId);
map.set(id, data);
},
/**
Expand All @@ -82,7 +81,7 @@ const hooks = asyncHooks.createHook({
if (!map.has(id)) {
return;
}
debug(`destroy ${id}`);
debug('destroy %d', id);
map.delete(id);
},
});
Expand Down Expand Up @@ -135,8 +134,8 @@ exports.disableLinkedTop = () => {
/**
* Set the key/value for this score
* @param {String} key The key of value
* @param {String} value The value
* @param {Boolean} linkedTop The value linked to top
* @param {any} value The value
* @param {Boolean} [linkedTop] The value linked to top
* @returns {Boolean} if success, will return true, otherwise false
*/
exports.set = function setValue(key, value, linkedTop) {
Expand All @@ -145,7 +144,7 @@ exports.set = function setValue(key, value, linkedTop) {
throw new Error('can\'t set created and parent');
}
const id = getCurrentId();
debug(`set ${key}:${value} to ${id}`);
debug('set %s:%j to %d', key, value, id);
let data = map.get(id);
/* istanbul ignore if */
if (!data) {
Expand All @@ -169,7 +168,7 @@ exports.set = function setValue(key, value, linkedTop) {
exports.get = function getValue(key) {
const data = map.get(getCurrentId());
const value = get(data, key);
debug(`get ${key}:${value} from ${currentId}`);
debug('get %s:%j from %d', key, value, currentId);
return value;
};

Expand Down