Repository navigation
Merge main into release/14.0.0 - #2306
Merged
Merged
Conversation
FilePickerDelegate dropped activity results with an unexpected result code, a confirmed save without a location, and picks without a type, so the Dart call never completed and every later pick failed with already_active. They now fail with unknown_result or invalid_type, decided by a JVM tested ResultOutcome. Results of activities started by other plugins are no longer answered as an error of a pending pick, and a SecurityException while writing a saved file now fails the save instead of crashing the app. On Android and Darwin, onFileSaving now also reports done when saving fails, and an error of the status stream is ignored instead of thrown as an uncaught error. Bumps android_file_picker to 2.1.3, file_picker_darwin to 2.4.2 and file_picker to 13.3.2.
2.0.1 raised dbus to ^0.8.0 through a Dependabot bump that nothing needed, so apps that also use a plugin still on dbus 0.7, such as geolocator_linux, could no longer resolve once the facade required file_picker_linux ^2.0.2. Allow >=0.7.13 <0.9.0 and keep Dependabot from raising the lower bound again.
Co-authored-by: Navaron Bracke <brackenavaron@gmail.com>
Always answer Android picks and saves
Let file_picker_linux resolve against dbus 0.7 again
Brings the 13.x fixes published as android_file_picker 2.1.3, file_picker_darwin 2.4.2, file_picker_linux 2.0.3 and file_picker 13.3.2 into v14 (#2302, #2305). The versions and the facade constraints stay at the v14 ones. Each CHANGELOG keeps its v14 section on top of the new 13.x one. The Android tests keep both the v14 tests and the new status update tests.
navaronbracke
approved these changes
Nov 2, 2026
vicajilau
added a commit
that referenced
this pull request
Nov 2, 2026
Brings in the 13.x fixes merged through #2306. The status stream and saveFile() fixes of #2302 merged cleanly into the Pigeon version. The conflict in pickFiles() keeps the Pigeon call, without the catch that only rethrew, which #2302 removed. The two status update tests of #2302 mocked the method channel, which is gone, so they now answer through a FakeFilePickerApi. Both still fail without the fixes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2224. Brings the 13.x fixes published today into
release/14.0.0:android_file_picker2.1.3,file_picker_darwin2.4.2,file_picker13.3.2)dbusrange offile_picker_linux(2.0.3), so 3.0.0 also resolves next to plugins on dbus 0.7Conflicts
file_picker_android_test.dartkeeps both the v14 tests and the new status update tests.#2304 moves the Android tests onto a fake
FilePickerApi, so it will need the status update tests ported once this is in.Tests
dart format,flutter analyzeandflutter testpass in every package, as doflutter test tool/testand./gradlew :android_file_picker:testDebugUnitTest.Merge it with a merge commit, not a squash, so
mainstays an ancestor of the release branch.