Skip to content

Add observability when dropping/gathering ice candidates #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add observability when dropping/gathering ice candidates #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion src/rpc/signaling-exchange.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,23 +255,38 @@ export class SignalingExchange {
candidate: RTCIceCandidateInit | null;
}) {
await this.remoteDescriptionSet;

if (this.exchangeDone || this.pc.iceConnectionState === 'connected') {
if (event.candidate !== null) {
// eslint-disable-next-line no-console
console.info('Dropping ICE candidate - exchange done or already connected', {
exchangeDone: this.exchangeDone,
iceConnectionState: this.pc.iceConnectionState,
candidate: event.candidate.candidate
});
}
return;
}

if (event.candidate === null) {
// eslint-disable-next-line no-console
console.info('ICE gathering complete');
this.iceComplete = true;
await this.sendDone();
return;
}

if (this.callUuid === undefined || this.callUuid === '') {
// eslint-disable-next-line no-console
console.error(callUUIDUnset);
throw new Error(callUUIDUnset);
}

if (event.candidate.candidate !== undefined) {
console.debug(`gathered local ICE ${event.candidate.candidate}`); // eslint-disable-line no-console
// eslint-disable-next-line no-console
console.info(`gathered local ICE ${event.candidate.candidate}`);
}

const iProto = iceCandidateToProto(event.candidate);
const callRequestUpdate = new CallUpdateRequest({
uuid: this.callUuid,
Expand All @@ -280,6 +295,7 @@ export class SignalingExchange {
value: iProto,
},
});

const callUpdateStart = new Date();
try {
await this.signalingClient.callUpdate(callRequestUpdate, this.callOpts);
Expand Down
Loading