Closes #295 bug(sdk): VestflowClient.createSchedule is missing lockup_duration in args array — all calls fail#350
Closed
dev-sylv wants to merge 6 commits into
Closed
Conversation
The contract's create_schedule expects lockup_duration between cliff_duration and kind (10 args total), but the SDK only sent 9, causing every createSchedule call to fail at RPC simulation. Adds optional lockupDays to CreateScheduleParams, defaulting to cliffDays, and inserts it at the correct index in the args array. Fixes vestflow-labs#295
|
@dev-sylv Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
ci checks failing |
…hecks express-rate-limit and @types/express-rate-limit were added to package.json without regenerating package-lock.json, so npm ci failed before tsc/next build ever ran (Backend Build, Frontend Build). MultiTokenVestingSchedule::claimable_at cast token_idx (u32) to usize before calling Vec::get()/comparing against len(), both of which expect u32 on soroban_sdk::Vec, breaking the contract build (Contract Build, Contract Tests, Testnet E2E Tests all depend on it compiling). Also fixes a pre-existing type error in stellar.test.ts (missing paused/requires_milestones in the ScheduleData test helper) inherited from main.
Contributor
|
please resolve |
…dule-lockup # Conflicts: # package-lock.json
Contributor
|
The Frontend build is Failing |
… lightningcss binary package-lock.json was last regenerated on Windows and only pins the win32 lightningcss optional binary, so npm ci never fetches lightningcss-linux-x64-gnu on the Ubuntu runner, breaking the Tailwind v4 build. npm install re-resolves optionalDependencies for the current platform. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
please resolve |
1 similar comment
Contributor
|
please resolve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #295 bug(sdk): VestflowClient.createSchedule is missing lockup_duration in args array — all calls fail
The contract's create_schedule expects lockup_duration between cliff_duration and kind (10 args total), but the SDK only sent 9, causing every createSchedule call to fail at RPC simulation.
Adds optional lockupDays to CreateScheduleParams, defaulting to cliffDays, and inserts it at the correct index in the args array.