Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Fixes #259
Description:
When exporting an execution plan using
FORMAT="tck", NebulaGraph Console displays the execution plan correctly in the terminal but writes only an empty line to the exported file.The issue occurs because the rendered TCK output is not assigned to the local variable
s, which is used by the common file export logic.How do you solve it?
p.renderByTck(rows)to the local variables.sinstead of callingp.renderByTck(rows)directly.This ensures that the TCK execution plan is correctly written to the exported file.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
printer/plan_desc_printer.go.row,dot, anddot:structbehavior remains unchanged.Reproduction:
Before this fix, the exported file contains only an empty line.
After this fix, the exported file contains the complete TCK-formatted execution plan.