Repository navigation
Conversation
Author
|
Hi @jievince, I've submitted several small bug fixes and improvements for nebula-console:
These PRs contain minimal changes and are intended to preserve backward compatibility. Could you please help review them when you have time? If everything looks good, I'd appreciate your help getting them merged. Thanks for your time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Fixes #254
Description:
When NebulaGraph Console starts without command-line flags, the startup notice incorrectly states that the default password is
nebula.However, the actual implementation initializes the password to an empty string and prompts the user to enter a password interactively.
This inconsistency may mislead users about the default login credentials.
How do you solve it?
Update the startup notice in
main.goto indicate that the password is initially empty and will be prompted interactively.Only the displayed message is changed. The existing authentication and connection behavior remain unchanged.
Special notes for your reviewer, ex. impact of this fix, design document, etc:
main.go.