Separate build step from test in CI #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-of-kpp
force-pushed
the
separate-build-step
branch
from
f64e82b to
e36fffa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on my previous attempt to set up multiarch builds in this repo (#496),
but it doesn't go as far.
Instead, here, I only separate the build and test from each other and save the Docker image in the CI cache. There are no other changes, and current Docker Hub builds should not be affected.
With this, it should not be hard to add more steps: call
docker manifest, push images, sign them, etc., e.g., if you'd like to remove DockerHub builds.This should also work with my vertexproject/synapse#4195 (in the future).