Skip to content

3xx: Add geo:locatable:address:city #4646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikemoritz wants to merge 2 commits into
base: synapse-3xx
Choose a base branch
from
+7 −0
Open

3xx: Add geo:locatable:address:city #4646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ca5fa2
add geo:locatable:address:city
mikemoritz Jan 2, 2026
81574d2
fix test
mikemoritz Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions synapse/models/geospace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,6 +413,9 @@ def repr(self, norm):
('address', ('geo:address', {}), {
'doc': 'The postal address where the {title} {happened}.'}),

('address:city', ('base:name', {}), {
'doc': 'The city where the {title} {happened}.'}),

('latlong', ('geo:latlong', {}), {
'doc': 'The latlong where the {title} {happened}.'}),

Expand Down
2 changes: 2 additions & 0 deletions synapse/tests/test_model_entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ async def test_model_entity(self):
:social:accounts={[ inet:service:account=({"name": "invisig0th"}) ]}
:birth:place:country:code=us
:death:place:country:code=zz
:place:address:city=" new York city "
]''')
self.len(1, nodes)
self.eq(nodes[0].get('name'), 'visi')
Expand All @@ -26,6 +27,7 @@ async def test_model_entity(self):
self.eq(nodes[0].get('websites'), ('https://vertex.link',))
self.eq(nodes[0].get('birth:place:country:code'), 'us')
self.eq(nodes[0].get('death:place:country:code'), 'zz')
self.eq(nodes[0].get('place:address:city'), 'new york city')
self.len(1, nodes[0].get('social:accounts'))
self.len(1, await core.nodes('entity:contact -> inet:service:account'))

Expand Down
2 changes: 2 additions & 0 deletions synapse/tests/test_model_geospace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,7 @@ async def test_types_forms(self):
:desc="The place where Vertex Project hangs out at!"
:name="Vertex HQ"
:address="208 Datong Road, Pudong District, Shanghai, China"
:address:city=" Shanghai "
:loc=us.hehe.haha
:photo=*
:latlong=(34.1341, -118.3215)
Expand All @@ -238,6 +239,7 @@ async def test_types_forms(self):
self.eq(node.get('altitude:accuracy'), 2000)
self.eq(node.get('desc'), 'The place where Vertex Project hangs out at!')
self.eq(node.get('address'), '208 datong road, pudong district, shanghai, china')
self.eq(node.get('address:city'), 'shanghai')
self.nn(node.get('photo'))

self.len(1, await core.nodes('geo:place :photo -> file:bytes'))
Expand Down