Skip to content

Conversation

@vEpiphyte
Copy link
Contributor

@vEpiphyte vEpiphyte commented Jan 2, 2026

Allow background tasks the opportunity to be awaited at the end of Base.main().

With telepath proxy Link teardown deferred to background tasks (#4166), this allows the links to be torn down by our application instead of being terminated at interpreter shutdown. These un-fini'd Link's are normally not seen in container based environments due to the usage of -O to remove __debug__ statements; which hides the log output showing the un-fini'd links in of the base._fini_atexit handler.

@vEpiphyte vEpiphyte marked this pull request as draft January 2, 2026 18:15
@codecov
Copy link

codecov bot commented Jan 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.72%. Comparing base (e6e3277) to head (3d82930).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4645   +/-   ##
=======================================
  Coverage   97.71%   97.72%           
=======================================
  Files         295      295           
  Lines       62057    62058    +1     
=======================================
+ Hits        60642    60645    +3     
+ Misses       1415     1413    -2     
Flag Coverage Δ
linux 97.65% <100.00%> (+<0.01%) ⬆️
linux_replay 93.38% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vEpiphyte vEpiphyte changed the title Dev - Allow background tasks the opportunity to be awaited in base.main() Dev - Allow background tasks the opportunity to be awaited in Base.main() Jan 2, 2026
@vEpiphyte vEpiphyte marked this pull request as ready for review January 2, 2026 19:45
@vEpiphyte vEpiphyte added this to the v2.2xx.x milestone Jan 3, 2026
@vEpiphyte vEpiphyte merged commit d280f44 into master Jan 3, 2026
6 checks passed
@vEpiphyte vEpiphyte deleted the bug_base_main_shutdown branch January 3, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants