Clean up some FIXMEs and TODOs #4643
Open
+81
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## synapse-3xx #4643 +/- ##
===============================================
+ Coverage 96.68% 96.72% +0.03%
===============================================
Files 252 252
Lines 60713 60716 +3
===============================================
+ Hits 58702 58728 +26
+ Misses 2011 1988 -23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
invisig0th
reviewed
Jan 2, 2026
| def getTagProps(self): | ||
| for form, tag, prop in self.getTagPropIndexes(): | ||
| if form is None and tag is not None: | ||
| yield tag, prop |
Contributor
There was a problem hiding this comment.
should the results be uniq?
Contributor
Author
There was a problem hiding this comment.
This is iterating the tagprop abrvs and filtering to only the tag+prop ones (skipping the form+tag+prop and prop only abrvs) so the results should be unique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.