Add vaults to pkgdef schema. resolves SYN-9842 #4590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4590 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 295 295
Lines 62047 62047
=======================================
Hits 60634 60634
Misses 1413 1413
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelSquires
requested changes
Nov 25, 2025
vEpiphyte
requested changes
Nov 30, 2025
MichaelSquires
requested changes
Dec 1, 2025
Contributor
MichaelSquires
left a comment
MichaelSquires
left a comment
There was a problem hiding this comment.
Looks good, but needs some tests.
invisig0th
previously approved these changes
Dec 1, 2025
MichaelSquires
previously approved these changes
Dec 2, 2025
vEpiphyte
previously approved these changes
Dec 2, 2025
Cisphyx
previously approved these changes
Dec 3, 2025
mikemoritz
requested changes
Dec 15, 2025
Contributor
There was a problem hiding this comment.
There's a bug that is preventing the schemas from validating: horejsek/python-fastjsonschema#201
I also added tests for this in another branch: #4621
invisig0th
dismissed stale reviews from Cisphyx, MichaelSquires, and vEpiphyte
via
84126ed
mikemoritz
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.