-
Notifications
You must be signed in to change notification settings - Fork 83
Move drive utils to 2.x and migrate perms #4366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4366 +/- ##
==========================================
- Coverage 97.38% 97.31% -0.07%
==========================================
Files 268 268
Lines 60700 60753 +53
==========================================
+ Hits 59111 59121 +10
- Misses 1589 1632 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
vEpiphyte
reviewed
Jun 26, 2025
vEpiphyte
reviewed
Jun 26, 2025
Cisphyx
reviewed
Jun 27, 2025
Cisphyx
previously approved these changes
Jun 27, 2025
vEpiphyte
reviewed
Jun 30, 2025
Co-authored-by: vEpiphyte <[email protected]>
vEpiphyte
approved these changes
Jun 30, 2025
Cisphyx
approved these changes
Jun 30, 2025
drakkhen
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this was cherry-picked from the 3.x PRs, but this one does include the migration for
perm->permissionsfor all the drive info items.