feat: find .tool-versions and legacy files until reach root directory and keep .tool-versions order.
#289
Conversation
|
It seems that there is no sorting implementation in |
Yes, only ensures that the order of adding. |
aooohan
force-pushed
the
feat/tool-version-behavior
branch
from
76d2508 to
4da6bab
Compare
| flushCache.Clear() | ||
| } | ||
| if item.Version == version { | ||
| logger.Debugf("Hit cache, skip flush envrionment, %s@%s\n", name, version) |
| } | ||
| wg.Wait() | ||
| } | ||
| if versionMap.Len() != 0 { |
There was a problem hiding this comment.
I may not understand the code correctly. As soon as the first .toolsversion is found, the recursion is stopped. However, it could be that not all SDKs are specified in this file. In other words, I would expect a combination of all .toolsversions from all paths. The global file has the lowest priority and then ascending according to proximity to the current working directory.
There was a problem hiding this comment.
You reminded me that the global .tool-versions file should be combined.
In other words, I would expect a combination of all .toolsversions from all paths
I don't agree to this point.
There was a problem hiding this comment.
I don't agree to this point.
Expressed incorrectly. I mean all files that can be found up to the root. Say the following example
If I enter folder childdir1, I will receive all SDK in .tool-versions file 1 and 3, but not 2.
There was a problem hiding this comment.
Sorry for the late reply. I have got it, and I will continue to improve this PR soon later.
fix #269
fix #228
fix #288