Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sender encodings priority option #893

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marcovidonis
Copy link

Addresses #873. Adds the option to set the sender's priority when adding local media stream tracks to the peer connection in RTCSession.

I added an optional field called encodingsPriority to the options passed to call() and to answer(). When not passed, the default value is applied ('low').

I tested this both on Chrome and Safari. While encodings setting appears successful in both, as it turns out, Safari doesn't actually apply the settings to the packet headers, as can be verified with Wireshark:

Chrome

gc image

Safari

saf image

This appears to be a bug in Safari (verified both in v17.x and v18.x) and we're going to report it to Safari's bug tracker.

Example usage

const SESSION_OPTIONS = {
    mediaConstraints: {
        audio: true,
        video: false
    },
    encodingsPriority: 'high',
};

const newSession = jssip.call(uri, SESSION_OPTIONS);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant