Repository navigation
[runtime, deps] fix: initialize rollout state with the current VeOmni API - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Standalone PP rollout workers fail at startup because VeOmni no longer exports
init_parallel_state. Initialize their non-EP state through the current publicAcceleratorConfig/init_parallel_state_from_configAPI. Use the initialized rollout process group's size even when the child inherits a differentWORLD_SIZEfrom its trainer.Design & Code Changes
vexact.utils.veomni_parallel_state; use only the current API, with no legacy fallback or verl plugin dependency.aa8bb43and verl to current upstream main8718ca30. The previously pinned verl engine also invoked the removed initializer. Align Transformers to 5.16.1 and TransferQueue to 0.1.10, then refresh the lock.tests/collection used by GPU CI.reject_requestkeyword. Preserve existing abort behavior forFalse;Trueraises a clearNotImplementedErrorbecause VeXact does not implement admission rejection.Test
WORLD_SIZE=16and actual group size 4. Each rank builds a CPU device mesh with DP size 4, EP disabled, unchanged environment, no verl import, and repeated initialization reusing the same state.examples/README.mdand.github/PULL_REQUEST_TEMPLATE.md; unrelated auto-edits were restored.uv lock --checkand the frozen GPU/dev/VeOmni/vLLM/verl dependency export passed.Checklist Before Submitting
CONTRIBUTING.mdand searched existing open PRs; no matching initializer repair was found.