Repository navigation
[ops] feat: Support GPT-OSS learnable attention sinks - #45
Merged
Merged
Conversation
Luosuu
commented
Aug 3, 2026
Luosuu
marked this pull request as ready for review
August 5, 2026 04:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
s_auxlogits to FA4 aslearnable_sinkfused_quackMoE implementation on the VeOmni actor and vexact rolloutWhy
Transformers'
GptOssAttentionpasses each layer's learned sink parameter ass_aux. The vexact FlashAttention wrapper previously accepted it through**kwargsbut discarded it, changing the softmax denominator and producing incorrect GPT-OSS attention outputs.The VeOmni actor already uses its GPT-OSS-specific interleaved gate/up quack kernel. Vexact now keeps the common Transformers
AutoModelForCausalLMloading path and applies a model-specific GPT-OSS experts patch, matching the actor arithmetic without adding GPT-OSS branches to the common loader.Validation
9 passed, 3 skipped13 passed10 passedGPT-OSS rollout requires
attn_impl=fa-invariant-cuteandmoe_implementation=fused_quack. Model configuration reports a clear error for unsupported choices.The full GPT-OSS VeRL one-step E2E has a strict
training/rollout_probs_diff_max == 0.0assertion prepared, but the latest 8×H100 launch is pending workspace group quota availability.