Skip to content

Refactor active-class-name example #8558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 29, 2019
Merged

Refactor active-class-name example #8558

merged 2 commits into from
Aug 29, 2019

Conversation

HaNdTriX
Copy link
Contributor

Changelog

  • use router hook instead of hoc
  • simplify ActiveLink component
  • add prop-types
  • add function names
  • use fragments instead of divs

@HaNdTriX
Refactor active-class-name example
c0a41bb 
- use router hook instead of hoc
- simplify ActiveLink component
- add prop-types
- add function names
- use fragments instead of divs
@HaNdTriX HaNdTriX requested review from lfades and Timer as code owners August 29, 2019 15:23
Timer
Timer approved these changes Aug 29, 2019
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks as always.

@Timer Timer added this to the 9.0.6 milestone Aug 29, 2019
@Timer Timer added ready to land examples Issue was opened via the examples template. labels Aug 29, 2019
@Timer Timer merged commit ce25f74 into vercel:canary Aug 29, 2019
@natkaratkova natkaratkova mentioned this pull request Sep 16, 2019
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
9.0.6
Development

Successfully merging this pull request may close these issues.
2 participants
@HaNdTriX @Timer