Skip to content

fix: port binding and multiple endpoint (#480) #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: port binding and multiple endpoint (#480) #481

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa2e14c
fix: port binding and multiple endpoint (#480)
oklas Feb 17, 2023
7ba9c9b
fix: select oveloaded variant of listen function
oklas Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/micro/src/bin/micro.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import type { RequestHandler } from '../lib';

// Check if the user defined any options
const args = arg({
'--listen': parseEndpoint,
'--listen': [parseEndpoint],
'-l': '--listen',
'--help': Boolean,
'--version': Boolean,
Expand Down Expand Up @@ -83,7 +83,7 @@ if (args['--version']) {

if (!args['--listen']) {
// default endpoint
args['--listen'] = [String(3000)];
args['--listen'] = [[String(3000)]];
}

let file = args._[0];
Expand Down Expand Up @@ -142,15 +142,15 @@ function registerShutdown(fn: () => void) {
process.on('exit', wrapper);
}

function startEndpoint(module: RequestHandler, endpoint: string) {
function startEndpoint(module: RequestHandler, endpoint: string[]) {
const server = new http.Server(serve(module));

server.on('error', (err) => {
console.error('micro:', err.stack);
process.exit(1);
});

server.listen(endpoint, () => {
const handler = () => {
const details = server.address();
registerShutdown(() => {
console.log('micro: Gracefully shutting down. Please wait...');
Expand All @@ -167,7 +167,12 @@ function startEndpoint(module: RequestHandler, endpoint: string) {
} else {
console.log('micro: Accepting connections');
}
});
};

if(endpoint.length === 2)
server.listen(parseInt(endpoint[0]||''), endpoint[1], handler);
else
server.listen(endpoint[0], handler);
}

async function start() {
Expand Down