feat: add data stream support to tools and use-chat #4789
+64
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgrammel
reviewed
Feb 9, 2025
| ); | ||
| }, | ||
| }; | ||
|
|
There was a problem hiding this comment.
at this stage we do not have a data stream so this goes against the architecture of streamText. agree with the general idea though - but the integration will not be that simple (thought about it quite a bit)
There was a problem hiding this comment.
Ah; yeah I was looking at the ai chatbot over the weekend and how it handles custom data.
Realized being able to write to a custom data stream would be pretty useful for execute and onToolCall, especially for longer tool calls with an api that supports streams.
Tried to find a good DX but yeah couldn’t exactly find best way to integrate data stream into stream text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4788