-
Notifications
You must be signed in to change notification settings - Fork 612
feat: add ARM64 support with smart browser selection and documentation #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adrianpuiu
wants to merge
8
commits into
vercel-labs:main
Choose a base branch
from
adrianpuiu:docs/add-browser-selection-and-arm64-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add ARM64 support with smart browser selection and documentation #252
adrianpuiu
wants to merge
8
commits into
vercel-labs:main
from
adrianpuiu:docs/add-browser-selection-and-arm64-support
+163
−1,682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Document Firefox and webkit browser options - Add recommendations for ARM64 systems - Include browser parameter examples - Add troubleshooting for ARM64
- Detect system architecture using os.arch() - Auto-select Firefox on ARM64 (native support) - Auto-select Chromium on x86_64 (traditional default) - Add informational logging on daemon startup - Log helpful warnings when Chromium requested on ARM64 - Maintain backward compatibility (explicit browser choice still works) - Fixes issue where ARM64 users hit 'Chromium not found' errors ARM64 Platform Support: - AWS Graviton instances - Azure Cobalt instances - On-premises ARM64 deployments - Docker containers (linux/arm64v8) - Apple Silicon (M1+) Browser Selection Logic: - No browser specified on ARM64 → Firefox (auto) - No browser specified on x86_64 → Chromium (auto) - browser: 'firefox' specified → Firefox (respected) - browser: 'chromium' specified → Chromium (with warning on ARM64)
- Remove non-existent --browser CLI flag examples - Remove non-existent AGENT_BROWSER_BROWSER environment variable - Update documentation to show only programmatic API examples - Fix ARM64 troubleshooting section with correct setup - Addresses Vercel bot feedback on undocumented CLI usage
- Extensions always require Chromium, so check for them first - On ARM64 with extensions but no browser specified, now uses Chromium - Adds warning when extensions + ARM64 since Chromium has limited ARM64 support - Prevents 'Extensions are only supported in Chromium' error on ARM64 - Maintains backward compatibility for all other scenarios
- Fix indentation of multiline string concatenations - Ensure compliance with repository's code style requirements
Contributor
|
@adrianpuiu is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add comprehensive ARM64 support to agent-browser with smart browser selection and updated documentation.
This PR solves the "Chromium not found" error that ARM64 users encounter by automatically detecting system architecture and selecting the best browser for the platform.
Problem
Users on ARM64 systems (AWS Graviton, Azure Cobalt, on-premises servers) encounter errors:
Solution
Code Changes (src/browser.ts, src/daemon.ts)
os.arch()Documentation Changes (docs/src/app/installation/page.tsx)
Testing
Impact
Solves issues for:
Benefits
✅ Automatic - Works without user configuration
✅ Smart - Uses best browser for each platform
✅ Helpful - Logs guidance to users
✅ Safe - Backward compatible, no breaking changes
✅ Complete - Includes code + docs + guidance
Commits