fix: add profile field to launchSchema in protocol.ts #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --profile flag was added in PR vercel-labs#68 but the profile field was missing from the Zod validation schema in protocol.ts. This caused the profile option to be stripped during command parsing, preventing persistent browser profiles from working. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
|
@ianwatts22 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
profilefield to thelaunchSchemaZod validation schema inprotocol.tsProblem
The
--profileflag was added in PR #68 to support persistent browser profiles, but theprofilefield was not added to the Zod schema inprotocol.ts. This caused the profile option to be stripped during command parsing, making the feature non-functional.Solution
Added
profile: z.string().optional()to thelaunchSchema, allowing the profile path to be passed through to the browser launch options.Test plan
agent-browser --profile ~/.browser-profiles/test --headed open https://example.comcreates profile directory🤖 Generated with Claude Code