Skip to content

Fix keyboard events for Backspace/Delete keys #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gdaybrice wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix keyboard events for Backspace/Delete keys #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1314,6 +1314,7 @@ export class BrowserManager {
key?: string;
code?: string;
text?: string;
keyCode?: number;
modifiers?: number; // 1=Alt, 2=Ctrl, 4=Meta, 8=Shift
}): Promise<void> {
const cdp = await this.getCDPSession();
Expand All @@ -1323,6 +1324,8 @@ export class BrowserManager {
key: params.key,
code: params.code,
text: params.text,
windowsVirtualKeyCode: params.keyCode,
nativeVirtualKeyCode: params.keyCode,
Copy link
Contributor

@vercel vercel bot Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeVirtualKeyCode: params.keyCode,

Incorrectly setting both windowsVirtualKeyCode and nativeVirtualKeyCode to the same Windows key code value, causing keyboard events to not work correctly on non-Windows platforms (macOS, Linux)

Fix on Vercel

modifiers: params.modifiers ?? 0,
});
}
Expand Down
2 changes: 2 additions & 0 deletions src/stream-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export interface InputKeyboardMessage {
key?: string;
code?: string;
text?: string;
keyCode?: number;
modifiers?: number;
}

Expand Down Expand Up @@ -215,6 +216,7 @@ export class StreamServer {
key: message.key,
code: message.code,
text: message.text,
keyCode: message.keyCode,
modifiers: message.modifiers,
});
break;
Expand Down