fix: allow pages with empty URLs during CDP connection for Electron support #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport Electron apps often have pages with empty URLs during initialization or with file:// URLs. The previous filter `page.url()` excluded these pages because empty strings are falsy in JavaScript, causing "No page found" errors when connecting to Electron apps via CDP. This change removes the URL filter to allow all valid pages from browser contexts, enabling agent-browser to work with Electron apps. Fixes vercel-labs#187 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
@zerone0x is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| const allPages = contexts.flatMap((context) => context.pages()).filter((page) => page.url()); | ||
| // Get all pages from all contexts - don't filter by URL as Electron apps | ||
| // may have pages with empty URLs during initialization | ||
| const allPages = contexts.flatMap((context) => context.pages()); |
Contributor
There was a problem hiding this comment.
Calling getCDPSession() on a page with empty URL causes Playwright to hang indefinitely, reintroducing the issue from #102 that was fixed but then regressed when the filter was removed to support Electron apps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #187
Changes
src/browser.ts: Remove.filter((page) => page.url())from CDP connection codesrc/browser.test.ts: Update test to expect all pages including those with empty URLsProblem
When connecting to an Electron app via CDP (
--cdpflag), the connection fails with "No page found" even when the Electron window is open and has content loaded.The root cause was that Electron apps often have pages with empty URL strings (
"") during initialization. The filter.filter((page) => page.url())excluded these because empty strings are falsy in JavaScript.Solution
Remove the URL filter to allow all valid pages from browser contexts. The validation
if (allPages.length === 0)still ensures at least one page exists.🤖 Generated with Claude Code